Re: [PATCH net-next] net: samsung: sxgbe: Make sxgbe_drv_remove() return void

On Thu, May 11, 2023 at 12:28:54PM +0200, Simon Horman wrote:

On Thu, May 11, 2023 at 12:17:40PM +0200, Simon Horman wrote:

quoted

On Wed, May 10, 2023 at 10:02:47PM +0200, Uwe Kleine-König wrote:

quoted

sxgbe_drv_remove() returned zero unconditionally, so it can be converted
to return void without losing anything. The upside is that it becomes
more obvious in its callers that there is no error to handle.

Signed-off-by: Uwe Kleine-König <redacted>

Reviewed-by: Simon Horman <redacted>

Sorry, minor nit.
Perhaps the subject prefix should be 'net: sxgbe: ', for consistency.
Or 'sxgbe: ' because the 'net: ' part is largely meaningless.

I'd not drop "net:". Looking at the output of

	git log --format=%s next/master -- drivers/net/ethernet/samsung/sxgbe/ | sed 's/:[^:]*$//' | sort | uniq -c | sort -n

the clear winner is "net: sxgbe: ".

If and when I will resend this patch, I'll adapt accordingly. If it's
taken as is (or the committer adapts the subject line) that's fine for
me, too.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |