Thread (6 messages) 6 messages, 3 authors, 2023-05-12

Re: [PATCH net-next] net: samsung: sxgbe: Make sxgbe_drv_remove() return void

From: Simon Horman <hidden>
Date: 2023-05-11 10:29:03

On Thu, May 11, 2023 at 12:17:40PM +0200, Simon Horman wrote:
On Wed, May 10, 2023 at 10:02:47PM +0200, Uwe Kleine-König wrote:
quoted
sxgbe_drv_remove() returned zero unconditionally, so it can be converted
to return void without losing anything. The upside is that it becomes
more obvious in its callers that there is no error to handle.

Signed-off-by: Uwe Kleine-König <redacted>
Reviewed-by: Simon Horman <redacted>
Sorry, minor nit.
Perhaps the subject prefix should be 'net: sxgbe: ', for consistency.
Or 'sxgbe: ' because the 'net: ' part is largely meaningless.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help