Re: [net-next PATCH 08/11] dt-bindings: net: dsa: dsa-port: Document support for LEDs node
From: Andrew Lunn <andrew@lunn.ch>
Date: 2023-03-08 01:00:23
Also in:
linux-arm-kernel, linux-devicetree, linux-leds, lkml
On Tue, Mar 07, 2023 at 06:00:43PM +0100, Christian Marangi wrote:
quoted hunk ↗ jump to hunk
Document support for LEDs node in dsa port. Switch may support different LEDs that can be configured for different operation like blinking on traffic event or port link. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- Documentation/devicetree/bindings/net/dsa/dsa-port.yaml | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml index 480120469953..f813e1f64f75 100644 --- a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml +++ b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml@@ -59,6 +59,13 @@ properties: - rtl8_4t - seville + leds: + type: object + + patternProperties: + '^led(@[a-f0-9]+)?$': + $ref: /schemas/leds/common.yaml#
Please could you add a description here documenting that these are LEDs the switch controls in its MACs. They are not LEDs in the possibly integrated PHY, which the PHY driver controls. We got this wrong, so i'm sure others will as well. So a bit of documentation should help avoid this. Andrew