Re: [PATCH net-next v2 5/6] tools: ynl: Add fixed-header support to ynl
From: Donald Hunter <donald.hunter@gmail.com>
Date: 2023-03-22 11:55:44
From: Donald Hunter <donald.hunter@gmail.com>
Date: 2023-03-22 11:55:44
Jakub Kicinski [off-list ref] writes:
On Sun, 19 Mar 2023 19:38:02 +0000 Donald Hunter wrote:quoted
def _dictify_ops_directional(self): + default_fixed_header = self.yaml['operations'].get('fixed-header') req_val = rsp_val = 1 for elem in self.yaml['operations']['list']: if 'notify' in elem:@@ -426,7 +430,7 @@ class SpecFamily(SpecElement): else: raise Exception("Can't parse directional ops") - op = self.new_operation(elem, req_val, rsp_val) + op = self.new_operation(elem, req_val, rsp_val, default_fixed_header)Can we record the "family-default" fixed header in the family and read from there rather than passing the arg around?
Yes, will do.
Also - doc - to be clear - by documentation I mean in the right places under Documentation/user-api/netlink/
Ack.