Re: [RFC PATCH v1 01/12] vsock: check error queue to set EPOLLERR
From: Krasnov Arseniy <hidden>
Date: 2023-02-20 09:00:51
Also in:
kvm, lkml
From: Krasnov Arseniy <hidden>
Date: 2023-02-20 09:00:51
Also in:
kvm, lkml
On 16.02.2023 16:40, Stefano Garzarella wrote:
On Mon, Feb 06, 2023 at 06:53:22AM +0000, Arseniy Krasnov wrote:quoted
If socket's error queue is not empty, EPOLLERR must be set.Could this patch go regardless of this series? Can you explain (even in the commit message) what happens without this patch?
Sure! Thanks
Thanks, Stefanoquoted
Signed-off-by: Arseniy Krasnov <redacted> --- net/vmw_vsock/af_vsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 19aea7cba26e..b5e51ef4a74c 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/af_vsock.c@@ -1026,7 +1026,7 @@ static __poll_t vsock_poll(struct file *file, struct socket *sock,poll_wait(file, sk_sleep(sk), wait); mask = 0; - if (sk->sk_err) + if (sk->sk_err || !skb_queue_empty_lockless(&sk->sk_error_queue)) /* Signify that there has been an error on this socket. */ mask |= EPOLLERR; -- 2.25.1