Re: [PATCH v3 08/26] page_pool: Convert pp_alloc_cache to contain netmem

From
Shay Agroskin <hidden>
Date
2023-01-15 11:20:38
Also in
linux-mm
Reply to
Matthew Wilcox, 2023-01-14
Matthew Wilcox [off-list ref] writes:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



On Sat, Jan 14, 2023 at 02:28:50PM +0200, Shay Agroskin wrote:
quoted
quoted
    memset(&pool->alloc.cache, 0, sizeof(void *) * bulk);
    nr_pages = alloc_pages_bulk_array_node(gfp, pool->p.nid,     bulk,
- pool->alloc.cache);
+                                   (struct page **)pool->alloc.cache);
Can you fix the alignment here (so that the '(struct page **)' would align
the the 'gfp' argument one line above) ?
No, that makes the line too long.
Couldn't find any word about inlining in the coding style. AFAIK 82 characters line is considered ok (and the file you're editing has even longer lines than that). To me it'd look better aligned, but suit yourself
Thread (41 messages) 41 messages, 5 authors, last reply 2023-01-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help