On Thu, Jan 12, 2023 at 05:36:58PM +0200, Shay Agroskin wrote:
"Matthew Wilcox (Oracle)" [off-list ref] writes:
quoted
Convert __page_pool_alloc_page_order() and
__page_pool_alloc_pages_slow()
...
TRACE_EVENT(page_pool_update_nid,
diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index 437241aba5a7..4e985502c569 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
...
@@ -421,7 +422,8 @@ static struct page
*__page_pool_alloc_pages_slow(struct page_pool *pool,
page = NULL;
}
- /* When page just alloc'ed is should/must have refcnt 1. */
+ /* When page just allocated it should have refcnt 1 (but may have
+ * speculative references) */
Sorry for the pity comment, but the comment style here is inconsistent
https://www.kernel.org/doc/html/v4.11/process/coding-style.html#commenting
You should have the last '*/' to be on its own line
(again sorry for not giving more useful feedback... then again, it's a
rather simply fix (: )
But networking doesn't follow that part of coding style.