Hi Rob,

On 2023/1/31 06:41, Rob Herring wrote:

On Mon, Jan 30, 2023 at 02:35:35PM +0800, Frank Sae wrote:

quoted

 Add a YAML binding document for the Motorcom yt8xxx Ethernet phy driver.

Bindings are for h/w devices, not drivers.

quoted

 
Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com>
---
 .../bindings/net/motorcomm,yt8xxx.yaml        | 102 ++++++++++++++++++
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 MAINTAINERS                                   |   1 +
 3 files changed, 105 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml

diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
new file mode 100644
index 000000000000..8527576c15b3
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml

@@ -0,0 +1,102 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/motorcomm,yt8xxx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MotorComm yt8xxx Ethernet PHY
+
+maintainers:
+  - frank sae <frank.sae@motor-comm.com>
+
+allOf:
+  - $ref: ethernet-phy.yaml#

This schema doesn't work because there is no way to determine whether to 
apply it or not. You need a compatible for your phy.

 I don't understand how to add a compatible for my phy.

compatible:
    oneOf:
      - enum:
          - fsl,imx25-fec
          - fsl,imx27-fec

compatible usually like this, but it is usually for mac or mdio.


phy id list:
YT8511	0x0000010a
YT8521	0x0000011A
YT8531  0x4f51e91b

motorcomm,yt8xxx.yaml

    mdio0 {
        ...
        ethernet-phy@5 {
            compatible = "ethernet-phy-id0000.010a",
                         "ethernet-phy-id0000.011a",
                         "ethernet-phy-id4f51.e91b",
                         "ethernet-phy-ieee802.3-c22";
            reg = <5>;
            ...
        };
    };

 Should i add compatible like this ? 
 If above is error, please give me an example, thanks!

Rob