Re: [PATCH net-next v2 06/15] devlink: use an explicit structure for dump context

Thu, Jan 05, 2023 at 05:05:22AM CET, kuba@kernel.org wrote:

Create a dump context structure instead of using cb->args
as an unsigned long array. This is a pure conversion which
is intended to be as much of a noop as possible.
Subsequent changes will use this to simplify the code.

The two non-trivial parts are:
- devlink_nl_cmd_health_reporter_dump_get_dumpit() checks args[0]
  to see if devlink_fmsg_dumpit() has already been called (whether
  this is the first msg), but doesn't use the exact value, so we
  can drop the local variable there already
- devlink_nl_cmd_region_read_dumpit() uses args[0] for address
  but we'll use args[1] now, shouldn't matter

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Jiri Pirko <redacted>