Re: [PATCH v1 3/7] dt-bindings: net: Add bindings for StarFive dwmac

On Thu, Dec 01, 2022 at 05:21:04PM +0100, Krzysztof Kozlowski wrote:

On 01/12/2022 10:02, Yanhong Wang wrote:

quoted

Add bindings for the StarFive dwmac module on the StarFive RISC-V SoCs.

Subject: drop second, redundant "bindings".

quoted

Signed-off-by: Yanhong Wang <redacted>
---
 .../devicetree/bindings/net/snps,dwmac.yaml   |   1 +
+properties:
+  compatible:
+    oneOf:

Drop oneOf. You do not have more cases here.

quoted

+      - items:
+          - enum:
+               - starfive,dwmac

Wrong indentation.... kind of expected since you did not test the bindings.

quoted

+          - const: snps,dwmac-5.20

Disclaimer: no familiarity with the version info with DW stuff

Is it a bit foolish to call this binding "starfive,dwmac"? Could there
not be another StarFive SoC in the future that uses another DW mac IP
version & this would be better off as "starfive,jh7110-dwmac" or similar?

Thanks,
Conor.