Re: [PATCH v1 4/7] net: phy: motorcomm: Add YT8531 phy support
From: Andrew Lunn <andrew@lunn.ch>
Date: 2022-12-01 15:42:14
Also in:
linux-devicetree, linux-riscv, lkml
+static const struct ytphy_reg_field ytphy_rxtxd_grp[] = {
+ { "rx_delay_sel", GENMASK(13, 10), 0x0 },
+ { "tx_delay_sel_fe", GENMASK(7, 4), 0xf },
+ { "tx_delay_sel", GENMASK(3, 0), 0x1 }
+};
+
+static const struct ytphy_reg_field ytphy_txinver_grp[] = {
+ { "tx_inverted_1000", BIT(14), 0x0 },
+ { "tx_inverted_100", BIT(14), 0x0 },
+ { "tx_inverted_10", BIT(14), 0x0 }
+};
+
+static const struct ytphy_reg_field ytphy_rxden_grp[] = {
+ { "rxc_dly_en", BIT(8), 0x1 }
+};
+
+static int ytphy_config_init(struct phy_device *phydev)
+{
+ struct device_node *of_node;
+ u32 val;
+ u32 mask;
+ u32 cfg;
+ int ret;
+ int i = 0;
+
+ of_node = phydev->mdio.dev.of_node;
+ if (of_node) {
+ ret = of_property_read_u32(of_node, ytphy_rxden_grp[0].name, &cfg);
You need to document the device tree binding.
Frank Sae always gets the locking wrong in this driver. Have you
tested your patch with lockdep enabled?
Andrew