Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings
From: Krzysztof Kozlowski <hidden>
Date: 2022-11-04 12:57:26
Also in:
linux-arm-kernel, linux-devicetree, lkml
On 04/11/2022 03:28, Md Danish Anwar wrote:
quoted
quoted
* It includes indentation, formatting, and other minor changes. --- .../bindings/net/ti,icssg-prueth.yaml | 181 ++++++++++++++++++ 1 file changed, 181 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/ti,icssg-prueth.yamldiff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml new file mode 100644 index 000000000000..40af968e9178 --- /dev/null +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml@@ -0,0 +1,181 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/ti,icssg-prueth.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: |+Missed Rob's comment.I'll remove this in the next version of this series.quoted
quoted
+ Texas Instruments ICSSG PRUSS Ethernet + +maintainers: + - Puranjay Mohan [off-list ref] + +description: + Ethernet based on the Programmable Real-Time + Unit and Industrial Communication Subsystem. + +allOf: + - $ref: /schemas/remoteproc/ti,pru-consumer.yaml# + +properties: + compatible: + enum: + - ti,am654-icssg-prueth # for AM65x SoC family + + pinctrl-0: + maxItems: 1 + + pinctrl-names: + items: + - const: defaultYou do not need these usually, they are coming from schema.Here from what I understand, I need to delete the below block, right?
Yes, entire pinctrl-0 and pinctr-names are not needed. You specify them ony if they differ from usual. Best regards, Krzysztof