RE: [PATCH net-next v4 RESEND] stmmac: tegra: Add MGBE support

Hi Vladimir,

-----Original Message-----
From: Vladimir Oltean <olteanv@gmail.com>
Sent: 18 November 2022 06:32 PM
To: Bhadram Varka <redacted>
Cc: Florian Fainelli <f.fainelli@gmail.com>; Thierry Reding
[off-list ref]; David S . Miller [off-list ref]; Eric
Dumazet [off-list ref]; Jakub Kicinski [off-list ref];
Paolo Abeni [off-list ref]; Russell King [off-list ref];
Andrew Lunn [off-list ref]; Revanth Kumar Uppala
[off-list ref]; Jonathan Hunter [off-list ref]; linux-
tegra@vger.kernel.org; netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 RESEND] stmmac: tegra: Add MGBE support

External email: Use caution opening links or attachments


Hi Bhadram,

On Wed, Oct 12, 2022 at 04:56:52AM +0000, Bhadram Varka wrote:

quoted

quoted

You should be modeling this as a proper PCS driver and have a 'pcs-

handle'

quoted

quoted

property pointing to it in your Device Tree.

The configuration you are doing here is probably working the first
time you bring-up the network device but I doubt it works across
system suspend/resume states where power to the GMAC and PCS is
lost, it also begs the question of which mediums this was tested
with and whether dynamic switching of speeds and so on is working?
--

For Tegra234, there is UPHY lanes control logic inside XPCS IP which is

memory-mapped IP (not part of the MAC IP).

quoted

mgbe_uphy_lane_bringup performs UPHY lane bring up here. Here

MGBE/XPCS works in XFI mode.

quoted

Agree that lane bring down logic is not present interface down/suspend

paths. Will update the changes accordingly.

quoted

One more thing is that UPHY lane bring should happen only after the line

side link is up. This also will make the changes.

quoted

Please let me know if I miss anything here.

What about the non-UPHY part of the XPCS IP, how does the dwmac-tegra.c
driver control it/see the status it reports?

Reset values of XPCS IP take care of configuring the IP in 10G mode. No need for extra register programming is required from the driver side. The only status that the driver expects from XPCS IP is RLU to be up which will be done by serdes_up in recent posted changes. Please let me know if any other queries on recent changes [0]

Thank You!

[0]: https://patchwork.ozlabs.org/project/linux-tegra/patch/20221118075744.49442-2-ruppala@nvidia.com/