On Tue, Nov 15, 2022 at 7:44 AM Hangbin Liu [off-list ref] wrote:

On Mon, Nov 14, 2022 at 08:51:43PM -0800, Jakub Kicinski wrote:

quoted

quoted

So maybe I should stop on here?

It's a bit of a catch 22 - I don't mind the TCA_NTF_WARN_MSG itself
but I would prefer for the extack via notification to spread to other
notifications.

Not sure if we could find a way to pass the GROUP ID to netlink_ack(),
and use nlmsg_notify() instead of nlmsg_unicast() in it. Then the tc monitor
could handle the NLMSG_ERROR directly.

That's what I meant. Do you have time to try this? Otherwise i will make time.
Your patch is still very specific to cls. If you only look at h/w
offload, actions can also
be added independently and fail independently as well. But in general this would
be useful for all notifications.

cheers,
jamal