Thread (30 messages) 30 messages, 5 authors, 2022-11-30

Re: [PATCH (repost) net-next] sched: add extack for tfilter_notify

From: Hangbin Liu <hidden>
Date: 2022-11-04 02:39:43

On Wed, Nov 02, 2022 at 04:36:46PM -0700, Jakub Kicinski wrote:
quoted
I meant you only added it for filter notification - but such a feature would
be useful also for other tc pieces (like actions and qdiscs). Is there a better
way to do it such that the other tc parts may benefit (instead of just
filter_notify?).

Yes.
So looks good to me then.

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Thanks Jamal for the comments.
Eish.

Hangbin, I'm still against this. Please go back to my suggestions /
questions. A tracepoint or an attribute should do. Multi-part messages
are very hard to map to normal programming constructs, and I don't
think there is any precedent for mutli-part notifications.
OK, I will re-consider about how to implement it via tracepoint or an attribute.

Thanks
Hangbin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help