Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible
From: Rolf Eike Beer <hidden>
Date: 2022-10-13 11:40:55
Also in:
kernel-janitors, linux-arm-kernel, linux-block, linux-crypto, linux-doc, linux-fsdevel, linux-media, linux-mips, linux-mm, linux-mmc, linux-nvme, linux-patches, linux-rdma, linux-s390, linux-um, linux-usb, linux-wireless, lkml, loongarch, sparclinux
Am Donnerstag, 13. Oktober 2022, 12:16:35 CEST schrieb Florian Westphal:
Rolf Eike Beer [off-list ref] wrote:quoted
Florian, can you comment and maybe fix it?Can't comment, do not remember -- this was 5 years ago.quoted
Or you wanted to move the variable before the loop and keep the random state between the loops and only reseed when all '1' bits have been consumed.Probably. No clue, best to NOT change it to not block Jasons series and then just simplify this and remove all the useless shifts.
Sure. Jason, just in case you are going to do a v7 this could move to u8 then.
Attachments
- signature.asc [application/pgp-signature] 195 bytes