Re: [PATCH v6 4/7] treewide: use get_random_{u8,u16}() when possible, part 2
From: Heiko Carstens <hca@linux.ibm.com>
Date: 2022-10-11 10:01:40
Also in:
dri-devel, kernel-janitors, linux-block, linux-crypto, linux-doc, linux-fsdevel, linux-media, linux-mips, linux-mm, linux-mmc, linux-nvme, linux-patches, linux-rdma, linux-s390, linux-um, linux-usb, linux-wireless, linuxppc-dev, lkml, loongarch, sparclinux
On Mon, Oct 10, 2022 at 05:06:10PM -0600, Jason A. Donenfeld wrote:
Rather than truncate a 32-bit value to a 16-bit value or an 8-bit value,
simply use the get_random_{u8,u16}() functions, which are faster than
wasting the additional bytes from a 32-bit value. This was done by hand,
identifying all of the places where one of the random integer functions
was used in a non-32-bit context.
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Kees Cook <redacted>
Reviewed-by: Yury Norov <yury.norov@gmail.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
arch/s390/kernel/process.c | 2 +-For s390: Acked-by: Heiko Carstens <hca@linux.ibm.com>