Thread (17 messages) 17 messages, 4 authors, 2023-05-27

Re: [PATCH v2 3/4] sched/isolation: Add HK_TYPE_WQ to isolcpus=domain

From: kernel test robot <hidden>
Date: 2022-10-14 00:57:17
Also in: linux-crypto, lkml

Hi Leonardo,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master helgaas-pci/next tip/sched/core tj-wq/for-next linus/master v6.0 next-20221013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Leonardo-Bras/CPU-isolation-improvements/20221014-024707
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: x86_64-rhel-8.3-kunit
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/7df1006c37ca5353fda63cd01ebf5bf3a2ef6562
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Leonardo-Bras/CPU-isolation-improvements/20221014-024707
        git checkout 7df1006c37ca5353fda63cd01ebf5bf3a2ef6562
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/pci/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot [off-list ref]

All warnings (new ones prefixed by >>):

   drivers/pci/pci-driver.c: In function 'pci_call_probe':
quoted
drivers/pci/pci-driver.c:382:1: warning: label 'out' defined but not used [-Wunused-label]
     382 | out:
         | ^~~


vim +/out +382 drivers/pci/pci-driver.c

0b2c2a71e6f07fb Thomas Gleixner     2017-05-24  349  
d42c69972b853fd Andi Kleen          2005-07-06  350  static int pci_call_probe(struct pci_driver *drv, struct pci_dev *dev,
d42c69972b853fd Andi Kleen          2005-07-06  351  			  const struct pci_device_id *id)
d42c69972b853fd Andi Kleen          2005-07-06  352  {
0b2c2a71e6f07fb Thomas Gleixner     2017-05-24  353  	int error, node, cpu;
873392ca514f87e Rusty Russell       2008-12-31  354  	struct drv_dev_and_id ddi = { drv, dev, id };
873392ca514f87e Rusty Russell       2008-12-31  355  
12c3156f10c5d8c Alexander Duyck     2013-11-18  356  	/*
12c3156f10c5d8c Alexander Duyck     2013-11-18  357  	 * Execute driver initialization on node where the device is
12c3156f10c5d8c Alexander Duyck     2013-11-18  358  	 * attached.  This way the driver likely allocates its local memory
12c3156f10c5d8c Alexander Duyck     2013-11-18  359  	 * on the right node.
12c3156f10c5d8c Alexander Duyck     2013-11-18  360  	 */
873392ca514f87e Rusty Russell       2008-12-31  361  	node = dev_to_node(&dev->dev);
0b2c2a71e6f07fb Thomas Gleixner     2017-05-24  362  	dev->is_probed = 1;
0b2c2a71e6f07fb Thomas Gleixner     2017-05-24  363  
0b2c2a71e6f07fb Thomas Gleixner     2017-05-24  364  	cpu_hotplug_disable();
12c3156f10c5d8c Alexander Duyck     2013-11-18  365  
12c3156f10c5d8c Alexander Duyck     2013-11-18  366  	/*
0b2c2a71e6f07fb Thomas Gleixner     2017-05-24  367  	 * Prevent nesting work_on_cpu() for the case where a Virtual Function
0b2c2a71e6f07fb Thomas Gleixner     2017-05-24  368  	 * device is probed from work_on_cpu() of the Physical device.
12c3156f10c5d8c Alexander Duyck     2013-11-18  369  	 */
0b2c2a71e6f07fb Thomas Gleixner     2017-05-24  370  	if (node < 0 || node >= MAX_NUMNODES || !node_online(node) ||
9d42ea0d6984044 Frederic Weisbecker 2022-02-07  371  	    pci_physfn_is_probed(dev)) {
0b2c2a71e6f07fb Thomas Gleixner     2017-05-24  372  		cpu = nr_cpu_ids;
9d42ea0d6984044 Frederic Weisbecker 2022-02-07  373  	} else {
69a18b18699b596 Alex Belits         2020-06-25  374  		cpu = cpumask_any_and(cpumask_of_node(node),
7df1006c37ca535 Leonardo Bras       2022-10-13  375  				      housekeeping_cpumask(HK_TYPE_WQ));
9d42ea0d6984044 Frederic Weisbecker 2022-02-07  376  	}
0b2c2a71e6f07fb Thomas Gleixner     2017-05-24  377  
873392ca514f87e Rusty Russell       2008-12-31  378  	if (cpu < nr_cpu_ids)
873392ca514f87e Rusty Russell       2008-12-31  379  		error = work_on_cpu(cpu, local_pci_probe, &ddi);
873392ca514f87e Rusty Russell       2008-12-31  380  	else
873392ca514f87e Rusty Russell       2008-12-31  381  		error = local_pci_probe(&ddi);
9d42ea0d6984044 Frederic Weisbecker 2022-02-07 @382  out:
0b2c2a71e6f07fb Thomas Gleixner     2017-05-24  383  	dev->is_probed = 0;
0b2c2a71e6f07fb Thomas Gleixner     2017-05-24  384  	cpu_hotplug_enable();
d42c69972b853fd Andi Kleen          2005-07-06  385  	return error;
d42c69972b853fd Andi Kleen          2005-07-06  386  }
d42c69972b853fd Andi Kleen          2005-07-06  387  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help