Re: [PATCH net-next] net: drop the weight argument from netif_napi_add

From
Eric Dumazet <hidden>
Date
2022-09-27 18:38:52
Also in
linux-can, linux-wireless
Reply to
Jakub Kicinski, 2022-09-27
On Tue, Sep 27, 2022 at 11:18 AM Jakub Kicinski [off-list ref] wrote:
On Tue, 27 Sep 2022 10:54:49 -0700 Eric Dumazet wrote:
quoted
On Tue, Sep 27, 2022 at 6:28 AM Jakub Kicinski [off-list ref] wrote:
quoted
We tell driver developers to always pass NAPI_POLL_WEIGHT
as the weight to netif_napi_add(). This may be confusing
to newcomers, drop the weight argument, those who really
need to tweak the weight can use netif_napi_add_weight().

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Sure, but this kind of patch makes backports harder.
Not sure how confused are newcomers about this NAPI_POLL_WEIGHT....
I maintained this patch in my tree for a couple of releases (because
I was waiting for the _weight() version to propagate to non-netdev
trees) and the conflicts were minor. Three or so cases of new features
added to drivers which touched the NAPI calls (WiFi and embedded) and
the strlcpy -> strscpy patch, and, well, why did we take that in if we
worry about backports...

NAPI weight was already dead when I started hacking on the kernel
10 years ago. I don't think it's reasonable to keep dead stuff
in our APIs for backport's sake. Adding Jiri to CC in case I need
someone to back me up :)

The idea for this patch came because I was reviewing a driver which
was trying to do something clever with the weight.
No hard feelings, but the recent removal of netif_tx_napi_add() added
extra work for some of us ;)

Keeping around few helpers to keep API a bit stable would help I think.
Thread (11 messages) 11 messages, 7 authors, last reply 2022-10-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help