Re: [PATCH net-next] net: drop the weight argument from netif_napi_add

From
Dave Taht <hidden>
Date
2022-09-27 18:26:31
Also in
linux-can, linux-wireless
Reply to
Eric Dumazet, 2022-09-27
On Tue, Sep 27, 2022 at 11:21 AM Eric Dumazet [off-list ref] wrote:
On Tue, Sep 27, 2022 at 6:28 AM Jakub Kicinski [off-list ref] wrote:
quoted
We tell driver developers to always pass NAPI_POLL_WEIGHT
as the weight to netif_napi_add(). This may be confusing
to newcomers, drop the weight argument, those who really
need to tweak the weight can use netif_napi_add_weight().

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Sure, but this kind of patch makes backports harder.
Not sure how confused are newcomers about this NAPI_POLL_WEIGHT....
Ironically we've been fiddling with dramatically reducing the
NAPI_POLL_WEIGHT (8) on
several multicore arm systems, with good results, especially on ath10k.


-- 
FQ World Domination pending: https://blog.cerowrt.org/post/state_of_fq_codel/
Dave Täht CEO, TekLibre, LLC
Thread (11 messages) 11 messages, 7 authors, last reply 2022-10-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help