Re: [PATCH net-next 3/9] net: dsa: allow the DSA master to be seen and changed through rtnetlink
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2022-09-01 13:33:08
Also in:
lkml
On Wed, Aug 31, 2022 at 08:50:20PM -0700, Jakub Kicinski wrote:
net/dsa/port.c: In function ‘dsa_port_change_master’:
net/dsa/port.c:1414:13: warning: unused variable ‘port’ [-Wunused-variable]
1414 | int port = dp->index;
| ^~~~I did build patch by patch, but in the sea of stuff that got rebuilt when I modified include/uapi/linux/if_link.h, I couldn't notice anything.
I presume you had a look around what side effects setting rtnl_link_ops will have? Should .netns_refund be true?
I'm not quite sure what other side effects there will be. The netns_refund property should be set to true, yes.