Re: [PATCH net-next v8 1/6] net: dsa: mv88e6xxx: Add RMU enable for select switches.

On Fri, Sep 09, 2022 at 10:34:35AM -0700, Florian Fainelli wrote:

quoted

+	int (*rmu_enable)(struct mv88e6xxx_chip *chip, int port);

Change the argument name to upstream_port to match the implementation for
each chip that you are adding?

Or the implementations to "port", for that matter. But yes, please keep consistency.