Re: [PATCH net-next v8 1/6] net: dsa: mv88e6xxx: Add RMU enable for select switches.
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2022-09-09 17:34:43
On 9/9/2022 1:51 AM, Mattias Forsblad wrote:
Add RMU enable functionality for some Marvell SOHO switches. Reviewed-by: Andrew Lunn <andrew@lunn.ch>
No need for newline here.
Signed-off-by: Mattias Forsblad <redacted>
Just one nit, sorry about that: [snip]
quoted hunk ↗ jump to hunk
index e693154cf803..7ce3c41f6caf 100644--- a/drivers/net/dsa/mv88e6xxx/chip.h +++ b/drivers/net/dsa/mv88e6xxx/chip.h@@ -637,6 +637,7 @@ struct mv88e6xxx_ops { /* Remote Management Unit operations */ int (*rmu_disable)(struct mv88e6xxx_chip *chip); + int (*rmu_enable)(struct mv88e6xxx_chip *chip, int port);
Change the argument name to upstream_port to match the implementation for each chip that you are adding? -- Florian