Re: [PATCH net-next] dt-bindings: net: dsa: make phylink bindings required for CPU/DSA ports
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-08-01 16:23:02
Also in:
linux-devicetree
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-08-01 16:23:02
Also in:
linux-devicetree
On Sun, 31 Jul 2022 18:00:06 +0300 Vladimir Oltean wrote:
It is desirable that new DSA drivers are written to expect that all their ports register with phylink, and not rely on the DSA core's workarounds to skip this process. To that end, DSA is being changed to warn existing drivers when such DT blobs are in use: https://patchwork.kernel.org/project/netdevbpf/cover/20220729132119.1191227-1-vladimir.oltean@nxp.com/ Introduce another layer of validation in the DSA DT schema, and assert that CPU and DSA ports must have phylink-related properties present. Suggested-by: Rob Herring <robh+dt@kernel.org> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- I've sent this patch separately because at least right now I don't have a reason to resend the other 4 patches linked above, and this has no dependency on those.
If I'm reading https://lore.kernel.org/r/CAL_JsqKZ6cEny_xD8LUMQUR6AQ0q7JKZMmdP-9MUZxzzNxZ3JQ@mail.gmail.com/ (local) correctly - the warnings are expected but there needs to be a change to properties, so CR? (FWIW I'd lean towards allowing it still, even tho net-next got closed. Assuming v2 can get posted and acked today.)