Re: [PATCH net-next v1 1/7] dt-bindings: net: pse-dt: add bindings for generic PSE controller
flat view
From: Rob Herring <robh@kernel.org>
Date: 2022-08-22 18:44:38
Also in:
linux-devicetree, linux-doc, lkml
On Fri, Aug 19, 2022 at 02:01:03PM +0200, Oleksij Rempel wrote:
quoted hunk ↗ jump to hunk
Add binding for generic Ethernet PSE controller. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- .../bindings/net/pse-pd/generic-pse.yaml | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/pse-pd/generic-pse.yamldiff --git a/Documentation/devicetree/bindings/net/pse-pd/generic-pse.yaml b/Documentation/devicetree/bindings/net/pse-pd/generic-pse.yaml new file mode 100644 index 0000000000000..64f91efa79a56 --- /dev/null +++ b/Documentation/devicetree/bindings/net/pse-pd/generic-pse.yaml@@ -0,0 +1,40 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/pse-pd/generic-pse.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic Power Sourcing Equipment + +maintainers: + - Oleksij Rempel <o.rempel@pengutronix.de> + +description: | + Generic PSE controller. The device must be referenced by the PHY node + to control power injection to the Ethernet cable.
Isn't this separate from the PHY other than you need to associate supplies with ethernet ports? Is there a controller here? Or it is just a regulator consumer associated with an ethernet port?
quoted hunk ↗ jump to hunk
+ +properties: + compatible: + const: ieee802.3-podl-pse-generic
Is this for 802.3bu only (which is where PoDL comes from) or all the flavors? If all, do they need to be distinguished? 'generic' is redundant.
+ + '#pse-cells':
What's this for? You don't have a consumer.
quoted hunk ↗ jump to hunk
+ const: 0 + + ieee802.3-podl-pse-supply:
Seems a bit long
+ description: |
Don't need '|' if no formatting to maintain.
+ Power supply for the PSE controller
+
+additionalProperties: false
+
+required:
+ - compatible
+ - '#pse-cells'
+ - ieee802.3-podl-pse-supply
+
+examples:
+ - |
+ ethernet-pse-1 {
+ compatible = "ieee802.3-podl-pse-generic";
+ ieee802.3-podl-pse-supply = <®_t1l1>;
+ #pse-cells = <0>;
+ };
--
2.30.2