Thread (18 messages) 18 messages, 7 authors, 2022-09-02

Re: [PATCH net-next] net: ieee802154: Fix compilation error when CONFIG_IEEE802154_NL802154_EXPERIMENTAL is disabled

From: Stefan Schmidt <stefan@datenfreihafen.org>
Date: 2022-08-31 21:13:53

Hello Jakub.

On 31.08.22 23:09, Jakub Kicinski wrote:
On Wed, 31 Aug 2022 22:59:14 +0200 Stefan Schmidt wrote:
quoted
I was swamped today and I am only now finding time to go through mail.

Given the problem these ifdef are raising I am ok with having these
commands exposed without them.

Our main reason for having this feature marked as experimental is that
it does not have much exposure and we fear that some of it needs rewrites.

If that really is going to happen we will simply treat the current
commands as reserved/burned and come up with other ones if needed. While
I hope this will not be needed it is a fair plan for mitigating this.
Thanks for the replies. I keep going back and forth in my head on
what's better - un-hiding or just using NL802154_CMD_SET_WPAN_PHY_NETNS + 1
as the start of validation, since it's okay to break experimental commands.

Any preference?
We saw other problems with these being behind ifdefs from build and 
fuzzing bots. I say its time we un-hide and deal with them being 
formerly deprecated and replaced by something else if it really comes to 
changes for them (which we are not sure of)

regards
Stefan Schmidt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help