Thread (18 messages) 18 messages, 7 authors, 2022-09-02

Re: [PATCH net-next] net: ieee802154: Fix compilation error when CONFIG_IEEE802154_NL802154_EXPERIMENTAL is disabled

From: Alexander Aring <aahringo@redhat.com>
Date: 2022-08-31 19:21:27

Hi,

On Wed, Aug 31, 2022 at 2:26 PM Jakub Kicinski [off-list ref] wrote:
On Tue, 30 Aug 2022 23:31:24 -0700 Jakub Kicinski wrote:
quoted
Hm, let me add 802154 folks.

Either we should treat the commands as reserved in terms of uAPI
even if they get removed the IDs won't be reused, or they are for
testing purposes only.

In the former case we should just remove the #ifdef around the values
in the enum, it just leads to #ifdef proliferation while having no
functional impact.

In the latter case we should start error checking from the last
non-experimental command, as we don't care about breaking the
experimental ones.
I haven't gone thru all of my inbox yet, but I see no reply from Stefan
or Alexander. My vote is to un-hide the EXPERIMENTAL commands.
fine for me if it's still in nl802154 and ends in error if somebody
tries to use it and it's not compiled. But users should still consider
it's not a stable API yet and we don't care about breaking it for
now...

- Alex
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help