Thread (15 messages) 15 messages, 3 authors, 2022-08-19
STALE1403d

[RFC PATCH net-next 07/10] net: dsa: remove "breaking chain" comment from dsa_switch_event

From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2022-08-18 15:50:53
Subsystem: networking [dsa], networking [general], the rest · Maintainers: Andrew Lunn, Vladimir Oltean, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

With the introduction of robust notifier chains, it is certainly no
longer true to simply say in dsa_switch_event() that the chain is
broken.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/dsa/switch.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/net/dsa/switch.c b/net/dsa/switch.c
index e3a91f38c5db..37875960d3f0 100644
--- a/net/dsa/switch.c
+++ b/net/dsa/switch.c
@@ -987,10 +987,6 @@ static int dsa_switch_event(struct notifier_block *nb,
 		break;
 	}
 
-	if (err)
-		dev_dbg(ds->dev, "breaking chain for DSA event %lu (%d)\n",
-			event, err);
-
 	return notifier_from_errno(err);
 }
 
-- 
2.34.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help