Thread (15 messages) 15 messages, 3 authors, 2022-08-19
STALE1403d

[RFC PATCH net-next 05/10] Revert "net: dsa: felix: suppress non-changes to the tagging protocol"

From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2022-08-18 15:50:39
Subsystem: networking drivers, networking [dsa], ocelot ethernet switch driver, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vladimir Oltean, Linus Torvalds

This reverts commit 4c46bb49460ee14c69629e813640d8b929e88941.

This is no longer necessary now that dsa_tree_change_tag_proto() uses
dsa_tree_notify_robust() and hence, does not bother us with another
notifier for old_tag_ops once we've failed the change to the new one.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/dsa/ocelot/felix.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
index aadb0bd7c24f..859196898a7d 100644
--- a/drivers/net/dsa/ocelot/felix.c
+++ b/drivers/net/dsa/ocelot/felix.c
@@ -610,9 +610,6 @@ static int felix_change_tag_protocol(struct dsa_switch *ds,
 
 	old_proto_ops = felix->tag_proto_ops;
 
-	if (proto_ops == old_proto_ops)
-		return 0;
-
 	err = proto_ops->setup(ds);
 	if (err)
 		goto setup_failed;
-- 
2.34.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help