Thread (7 messages) 7 messages, 3 authors, 2022-07-29

Re: [PATCH] sched/net/act: Remove temporary state variables

flat view

From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-07-29 07:18:55
Also in: lkml

On Fri, 29 Jul 2022 09:00:07 +0200 Jiri Pirko wrote:
quoted
quoted
What backports do you have in mind exactly?  
Code backports. I don't understand the question.  
Code backports of what where?
Are you talking about:
1) mainline kernels
2) distrubutions kernels? Or even worse, in-house kernels of companies?

If 2), I believe it is not relevant for the upstream discussion, at all.
Fixes and stable. Frankly it's just a generic justification 
to discourage people from sending subjective code cleanups.
I'd never argue for the benefit of (2) :)

There's been a string of patches cleaning up return values
of functions in the last few days. If people have a lot of
time on their hands they should go do something useful, like
converting netdev features to a bitmap. Hell, go fix W=1 warnings, 
even easier.

The time spent reviewing those "cleanups" adds up, and I suspect
there's hundreds of places they can be applied. Hence my question
about automation... 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help