[PATCH] sched/net/act: Remove temporary state variables
flat view
STALE1552d
From: Li zeming <hidden>
Date: 2022-07-27 09:42:03
Also in:
lkml
Subsystem:
networking [general], tc subsystem, the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jamal Hadi Salim, Jiri Pirko, Linus Torvalds
The temporary variable ret could be removed and the corresponding state can be directly returned. Signed-off-by: Li zeming <redacted> --- net/sched/act_api.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index 817065aa2833..34b5eb52e68b 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c@@ -398,8 +398,6 @@ static int __tcf_action_put(struct tc_action *p, bool bind) static int __tcf_idr_release(struct tc_action *p, bool bind, bool strict) { - int ret = 0; - /* Release with strict==1 and bind==0 is only called through act API * interface (classifiers always bind). Only case when action with * positive reference count and zero bind count can exist is when it was
@@ -417,10 +415,10 @@ static int __tcf_idr_release(struct tc_action *p, bool bind, bool strict) return -EPERM; if (__tcf_action_put(p, bind)) - ret = ACT_P_DELETED; + return ACT_P_DELETED; } - return ret; + return 0; } int tcf_idr_release(struct tc_action *a, bool bind)
--
2.18.2