Subject: Re: [Patch v4 06/12] net: mana: Define data structures for protection
domain and memory registration

On Mon, Jul 11, 2022 at 01:29:08AM +0000, Dexuan Cui wrote:

quoted

quoted

From: longli@linuxonhyperv.com <redacted>
Sent: Wednesday, June 15, 2022 7:07 PM

The MANA hardware support protection domain and memory

registration

quoted

quoted

for

s/support/supports

quoted

diff --git a/drivers/net/ethernet/microsoft/mana/gdma.h

b/drivers/net/ethernet/microsoft/mana/gdma.h
index f945755760dc..b1bec8ab5695 100644

--- a/drivers/net/ethernet/microsoft/mana/gdma.h
+++ b/drivers/net/ethernet/microsoft/mana/gdma.h

@@ -27,6 +27,10 @@ enum gdma_request_type {
 	GDMA_CREATE_DMA_REGION		= 25,
 	GDMA_DMA_REGION_ADD_PAGES	= 26,
 	GDMA_DESTROY_DMA_REGION		= 27,
+	GDMA_CREATE_PD			= 29,
+	GDMA_DESTROY_PD			= 30,
+	GDMA_CREATE_MR			= 31,
+	GDMA_DESTROY_MR			= 32,

These are not used in this patch. They're used in the 12th patch for
the first time. Can we move these to that patch?

This looks like RDMA code anyhow, why is it under net/ethernet?

Jason

This header file belongs to the GDMA layer (as its filename implies) . It's a hardware communication layer used by both ethernet and RDMA for communicating with the hardware.

Some of the RDMA functionalities are implemented at GDMA layer in the PF running on the host, so the message definitions are also there.

Long