RE: [Patch v4 01/12] net: mana: Add support for auxiliary device

[Patch v4 00/12] Introduce Microsoft Azure Network Adapter (MANA) RDMA driver · <hidden> · 2022-06-16
[Patch v4 01/12] net: mana: Add support for auxiliary device · <hidden> · 2022-06-16
RE: [Patch v4 01/12] net: mana: Add support for auxiliary device · Dexuan Cui <decui@microsoft.com> · 2022-07-11
RE: [Patch v4 01/12] net: mana: Add support for auxiliary device · Long Li <longli@microsoft.com> · 2022-07-12
[Patch v4 02/12] net: mana: Record the physical address for doorbell page region · <hidden> · 2022-06-16
RE: [Patch v4 02/12] net: mana: Record the physical address for doorbell page region · Dexuan Cui <decui@microsoft.com> · 2022-07-11
[Patch v4 03/12] net: mana: Handle vport sharing between devices · <hidden> · 2022-06-16
RE: [Patch v4 03/12] net: mana: Handle vport sharing between devices · Dexuan Cui <decui@microsoft.com> · 2022-07-11
RE: [Patch v4 03/12] net: mana: Handle vport sharing between devices · Long Li <longli@microsoft.com> · 2022-07-12
Re: [Patch v4 03/12] net: mana: Handle vport sharing between devices · Jason Gunthorpe <jgg@ziepe.ca> · 2022-07-20
RE: [Patch v4 03/12] net: mana: Handle vport sharing between devices · Long Li <longli@microsoft.com> · 2022-07-21
Re: [Patch v4 03/12] net: mana: Handle vport sharing between devices · Jason Gunthorpe <jgg@ziepe.ca> · 2022-07-21
RE: [Patch v4 03/12] net: mana: Handle vport sharing between devices · Long Li <longli@microsoft.com> · 2022-07-21
Re: [Patch v4 03/12] net: mana: Handle vport sharing between devices · Jason Gunthorpe <jgg@ziepe.ca> · 2022-07-21
RE: [Patch v4 03/12] net: mana: Handle vport sharing between devices · Long Li <longli@microsoft.com> · 2022-07-29
Re: [Patch v4 03/12] net: mana: Handle vport sharing between devices · Jason Gunthorpe <jgg@ziepe.ca> · 2022-07-29
RE: [Patch v4 03/12] net: mana: Handle vport sharing between devices · Long Li <longli@microsoft.com> · 2022-07-29
Re: [Patch v4 03/12] net: mana: Handle vport sharing between devices · Jason Gunthorpe <jgg@ziepe.ca> · 2022-08-02
RE: [Patch v4 03/12] net: mana: Handle vport sharing between devices · Long Li <longli@microsoft.com> · 2022-08-03
[Patch v4 04/12] net: mana: Add functions for allocating doorbell page from GDMA · <hidden> · 2022-06-16
RE: [Patch v4 04/12] net: mana: Add functions for allocating doorbell page from GDMA · Dexuan Cui <decui@microsoft.com> · 2022-07-11
RE: [Patch v4 04/12] net: mana: Add functions for allocating doorbell page from GDMA · Long Li <longli@microsoft.com> · 2022-07-12
Re: [Patch v4 04/12] net: mana: Add functions for allocating doorbell page from GDMA · Jason Gunthorpe <jgg@ziepe.ca> · 2022-07-20
[Patch v4 08/12] net: mana: Record port number in netdev · <hidden> · 2022-06-16
RE: [Patch v4 08/12] net: mana: Record port number in netdev · Dexuan Cui <decui@microsoft.com> · 2022-07-11
[Patch v4 05/12] net: mana: Set the DMA device max segment size · <hidden> · 2022-06-16
RE: [Patch v4 05/12] net: mana: Set the DMA device max segment size · Dexuan Cui <decui@microsoft.com> · 2022-07-11
[Patch v4 07/12] net: mana: Export Work Queue functions for use by RDMA driver · <hidden> · 2022-06-16
RE: [Patch v4 07/12] net: mana: Export Work Queue functions for use by RDMA driver · Dexuan Cui <decui@microsoft.com> · 2022-07-11
RE: [Patch v4 07/12] net: mana: Export Work Queue functions for use by RDMA driver · Long Li <longli@microsoft.com> · 2022-07-12
[Patch v4 11/12] net: mana: Define and process GDMA response code GDMA_STATUS_MORE_ENTRIES · <hidden> · 2022-06-16
RE: [Patch v4 11/12] net: mana: Define and process GDMA response code GDMA_STATUS_MORE_ENTRIES · Dexuan Cui <decui@microsoft.com> · 2022-07-11
[Patch v4 09/12] net: mana: Move header files to a common location · <hidden> · 2022-06-16
RE: [Patch v4 09/12] net: mana: Move header files to a common location · Dexuan Cui <decui@microsoft.com> · 2022-07-11
[Patch v4 10/12] net: mana: Define max values for SGL entries · <hidden> · 2022-06-16
RE: [Patch v4 10/12] net: mana: Define max values for SGL entries · Dexuan Cui <decui@microsoft.com> · 2022-07-11
RE: [Patch v4 10/12] net: mana: Define max values for SGL entries · Long Li <longli@microsoft.com> · 2022-07-12
[Patch v4 06/12] net: mana: Define data structures for protection domain and memory registration · <hidden> · 2022-06-16
RE: [Patch v4 06/12] net: mana: Define data structures for protection domain and memory registration · Dexuan Cui <decui@microsoft.com> · 2022-07-11
RE: [Patch v4 06/12] net: mana: Define data structures for protection domain and memory registration · Ajay Sharma <hidden> · 2022-07-13
RE: [Patch v4 06/12] net: mana: Define data structures for protection domain and memory registration · Dexuan Cui <decui@microsoft.com> · 2022-07-13
Re: [Patch v4 06/12] net: mana: Define data structures for protection domain and memory registration · Jason Gunthorpe <jgg@ziepe.ca> · 2022-07-20
RE: [Patch v4 06/12] net: mana: Define data structures for protection domain and memory registration · Long Li <longli@microsoft.com> · 2022-07-21
[Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter · <hidden> · 2022-06-16
RE: [EXTERNAL] [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter · Ajay Sharma <hidden> · 2022-06-25
Re: [EXTERNAL] [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter · Jason Gunthorpe <jgg@ziepe.ca> · 2022-06-26
RE: [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter · Dexuan Cui <decui@microsoft.com> · 2022-07-11
RE: [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter · Ajay Sharma <hidden> · 2022-07-13
RE: [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter · Dexuan Cui <decui@microsoft.com> · 2022-07-13
Re: [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter · Greg KH <gregkh@linuxfoundation.org> · 2022-07-12
RE: [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter · Long Li <longli@microsoft.com> · 2022-07-12
Re: [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter · Greg KH <gregkh@linuxfoundation.org> · 2022-07-13
Re: [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter · Jason Gunthorpe <jgg@nvidia.com> · 2022-07-20
RE: [EXTERNAL] Re: [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter · Ajay Sharma <hidden> · 2022-07-21
Re: [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter · Cheng Xu <chengyou@linux.alibaba.com> · 2022-07-21
RE: [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter · Long Li <longli@microsoft.com> · 2022-07-21

From: Long Li <longli@microsoft.com>
Date: 2022-07-12 18:26:24
Also in: linux-hyperv, linux-rdma, lkml

Subject: RE: [Patch v4 01/12] net: mana: Add support for auxiliary device

quoted

From: longli@linuxonhyperv.com <redacted>
Sent: Wednesday, June 15, 2022 7:07 PM

...

quoted

+static int add_adev(struct gdma_dev *gd) {
+	int ret = 0;

No need to initialize it to 0.

quoted

+	struct mana_adev *madev;
+	struct auxiliary_device *adev;

davem would require the reverse xmas tree order :-)

Thank you, will send v5 to fix this.

Reviewed-by: Dexuan Cui <decui@microsoft.com>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help