Thread (8 messages) flat view 8 messages, 3 authors, 2022-04-25

Re: [PATCH net 2/3] ip6_gre: Make o_seqno start from 0 in native mode

From: William Tu <hidden>
Date: 2022-04-22 16:26:47
Also in: bpf, lkml

On Thu, Apr 21, 2022 at 3:08 PM Peilin Ye [off-list ref] wrote:
From: Peilin Ye <redacted>

For IP6GRE and IP6GRETAP devices, currently o_seqno starts from 1 in
native mode.  According to RFC 2890 2.2., "The first datagram is sent
with a sequence number of 0."  Fix it.

It is worth mentioning that o_seqno already starts from 0 in collect_md
mode, see the "if (tunnel->parms.collect_md)" clause in __gre6_xmit(),
where tunnel->o_seqno is passed to gre_build_header() before getting
incremented.

Fixes: c12b395a4664 ("gre: Support GRE over IPv6")
Signed-off-by: Peilin Ye <redacted>
LGTM
Acked-by: William Tu <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help