Thread (8 messages) flat view 8 messages, 3 authors, 2022-04-25

Re: [PATCH net 1/3] ip_gre: Make o_seqno start from 0 in native mode

From: William Tu <hidden>
Date: 2022-04-22 16:26:38
Also in: bpf, lkml

On Thu, Apr 21, 2022 at 3:08 PM Peilin Ye [off-list ref] wrote:
From: Peilin Ye <redacted>

For GRE and GRETAP devices, currently o_seqno starts from 1 in native
mode.  According to RFC 2890 2.2., "The first datagram is sent with a
sequence number of 0."  Fix it.

It is worth mentioning that o_seqno already starts from 0 in collect_md
mode, see gre_fb_xmit(), where tunnel->o_seqno is passed to
gre_build_header() before getting incremented.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Peilin Ye <redacted>
LGTM
Acked-by: William Tu <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help