RE: [PATCH v4 net-next 06/14] ipv6/gro: insert temporary HBH/jumbo header

-----Original Message-----
From: Eric Dumazet <edumazet@google.com>
Sent: Tuesday, March 15, 2022 9:11 AM
To: Alexander Duyck <alexanderduyck@fb.com>
Cc: Alexander H Duyck <redacted>; Eric Dumazet
[off-list ref]; David S . Miller [off-list ref];
Jakub Kicinski [off-list ref]; netdev [off-list ref]; Coco
Li [off-list ref]
Subject: Re: [PATCH v4 net-next 06/14] ipv6/gro: insert temporary
HBH/jumbo header

On Tue, Mar 15, 2022 at 9:04 AM Alexander Duyck
[off-list ref] wrote:

quoted

quoted

-----Original Message-----
From: Eric Dumazet <edumazet@google.com>
Sent: Tuesday, March 15, 2022 9:02 AM
To: Alexander H Duyck <redacted>
Cc: Eric Dumazet <redacted>; David S . Miller
[off-list ref]; Jakub Kicinski [off-list ref]; netdev
[off-list ref]; Alexander Duyck

[off-list ref];

quoted

quoted

Coco Li [off-list ref]
Subject: Re: [PATCH v4 net-next 06/14] ipv6/gro: insert temporary
HBH/jumbo header

On Fri, Mar 11, 2022 at 8:24 AM Alexander H Duyck
[off-list ref] wrote:

quoted

On Wed, 2022-03-09 at 21:46 -0800, Eric Dumazet wrote:

quoted

From: Eric Dumazet <edumazet@google.com>

Following patch will add GRO_IPV6_MAX_SIZE, allowing gro to
build BIG TCP ipv6 packets (bigger than 64K).

This looks like it belongs in the next patch, not this one. This
patch is adding the HBH header.

What do you mean by "it belongs" ?

Do you want me to squash the patches, or remove the first sentence ?

I am confused.

It is about the sentence. Your next patch essentially has that as the title and

actually does add GRO_IPV6_MAX_SIZE. I wasn't sure if you reordered the
patches or split them. However as I recall I didn't see anything in this patch
that added GRO_IPV6_MAX_SIZE.


I used "Following patch will", meaning the patch following _this_ one, sorry if
this is confusing.

I would have used  "This patch is ..." if I wanted to describe what this patch is
doing.

Patches were not reordered, and have two different authors.

Yeah, the problem is I read "Following patch" as in the "The patch below". I would probably drop the line since it doesn't add much to the patch itself.