RE: [PATCH v4 net-next 06/14] ipv6/gro: insert temporary HBH/jumbo header
From: Alexander Duyck <alexanderduyck@fb.com>
Date: 2022-03-15 16:04:59
-----Original Message----- From: Eric Dumazet <edumazet@google.com> Sent: Tuesday, March 15, 2022 9:02 AM To: Alexander H Duyck <redacted> Cc: Eric Dumazet <redacted>; David S . Miller [off-list ref]; Jakub Kicinski [off-list ref]; netdev [off-list ref]; Alexander Duyck [off-list ref]; Coco Li [off-list ref] Subject: Re: [PATCH v4 net-next 06/14] ipv6/gro: insert temporary HBH/jumbo header On Fri, Mar 11, 2022 at 8:24 AM Alexander H Duyck [off-list ref] wrote:quoted
On Wed, 2022-03-09 at 21:46 -0800, Eric Dumazet wrote:quoted
From: Eric Dumazet <edumazet@google.com> Following patch will add GRO_IPV6_MAX_SIZE, allowing gro to build BIG TCP ipv6 packets (bigger than 64K).This looks like it belongs in the next patch, not this one. This patch is adding the HBH header.What do you mean by "it belongs" ? Do you want me to squash the patches, or remove the first sentence ? I am confused.
It is about the sentence. Your next patch essentially has that as the title and actually does add GRO_IPV6_MAX_SIZE. I wasn't sure if you reordered the patches or split them. However as I recall I didn't see anything in this patch that added GRO_IPV6_MAX_SIZE.