Re: [PATCH devicetree v3] dt-bindings: phy: Add `tx-p2p-microvolt` property binding
From: Rob Herring <robh@kernel.org>
Date: 2022-02-07 20:46:58
Also in:
linux-devicetree, linux-phy
On Wed, 19 Jan 2022 14:11:17 +0100, Marek Behún wrote:
Common PHYs and network PCSes often have the possibility to specify peak-to-peak voltage on the differential pair - the default voltage sometimes needs to be changed for a particular board. Add properties `tx-p2p-microvolt` and `tx-p2p-microvolt-names` for this purpose. The second property is needed to specify the mode for the corresponding voltage in the `tx-p2p-microvolt` property, if the voltage is to be used only for speficic mode. More voltage-mode pairs can be specified. Example usage with only one voltage (it will be used for all supported PHY modes, the `tx-p2p-microvolt-names` property is not needed in this case): tx-p2p-microvolt = <915000>; Example usage with voltages for multiple modes: tx-p2p-microvolt = <915000>, <1100000>, <1200000>; tx-p2p-microvolt-names = "2500base-x", "usb", "pcie"; Add these properties into a separate file phy/transmit-amplitude.yaml, which should be referenced by any binding that uses it. Signed-off-by: Marek Behún <kabel@kernel.org> --- Change since v2: - removed 'select:' as requested by Rob. Instead the schema should be referenced by any binding that uses it. This also fixed indentation warnings from Rob's bot, since they warned about lines in the select statement --- .../bindings/phy/transmit-amplitude.yaml | 103 ++++++++++++++++++ 1 file changed, 103 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/transmit-amplitude.yaml
Reviewed-by: Rob Herring <robh@kernel.org>