Thread (19 messages) 19 messages, 4 authors, 2022-02-07

Re: [PATCH v7 net-next 07/10] net: dsa: microchip: add support for ethtool port counters

From: Prasanna Vengateshan <hidden>
Date: 2022-02-07 17:11:17
Also in: linux-devicetree, lkml

On Fri, 2022-02-04 at 19:27 -0800, Jakub Kicinski wrote:
quoted
+     for (i = 0; i < dev->mib_cnt; i++) {
+             memcpy(buf + i * ETH_GSTRING_LEN, lan937x_mib_names[i].string,
+                    ETH_GSTRING_LEN);
+     }
parenthesis unnecessary around single expression

Also check out ethtool_sprintf(), although not strictly necessary since
you're not formatting
Sure, thanks for the feedback.

Prasanna V

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help