Re: [PATCH v7 net-next 05/10] net: dsa: microchip: add DSA support for microchip lan937x
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-02-05 03:27:40
Also in:
linux-devicetree, lkml
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-02-05 03:27:40
Also in:
linux-devicetree, lkml
On Fri, 4 Feb 2022 23:14:55 +0530 Prasanna Vengateshan wrote:
Basic DSA driver support for lan937x and the device will be configured through SPI interface. drivers/net/dsa/microchip/ path is already part of MAINTAINERS & the new files come under this path. Hence no update needed to the MAINTAINERS Reused KSZ APIs for port_bridge_join() & port_bridge_leave() and added support for port_stp_state_set() & port_fast_age(). lan937x_flush_dyn_mac_table() which gets called from port_fast_age() of KSZ common layer, hence added support for it. RGMII internal delay values for the mac is retrieved from rx-internal-delay-ps & tx-internal-delay-ps as per the feedback from v3 patch series. https://lore.kernel.org/netdev/20210802121550.gqgbipqdvp5x76ii@skbuf/ (local) It supports standard delay 2ns only. If the property is not found, the value will be forced to 0. Signed-off-by: Prasanna Vengateshan <redacted>
drivers/net/dsa/microchip/lan937x_dev.c:162:6: warning: no previous prototype for ‘lan937x_r_mib_pkt’ [-Wmissing-prototypes]
162 | void lan937x_r_mib_pkt(struct ksz_device *dev, int port, u16 addr,
| ^~~~~~~~~~~~~~~~~