Re: [PATCH net-next v5 05/13] net: wwan: t7xx: Add control port
From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Date: 2022-02-25 12:06:10
Also in:
linux-wireless
From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Date: 2022-02-25 12:06:10
Also in:
linux-wireless
On Wed, 23 Feb 2022, Ricardo Martinez wrote:
From: Haijun Liu <haijun.liu@mediatek.com> Control Port implements driver control messages such as modem-host handshaking, controls port enumeration, and handles exception messages. The handshaking process between the driver and the modem happens during the init sequence. The process involves the exchange of a list of supported runtime features to make sure that modem and host are ready to provide proper feature lists including port enumeration. Further features can be enabled and controlled in this handshaking process. Signed-off-by: Haijun Liu <haijun.liu@mediatek.com> Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com> Co-developed-by: Ricardo Martinez <ricardo.martinez@linux.intel.com> Signed-off-by: Ricardo Martinez <ricardo.martinez@linux.intel.com>quoted
From a WWAN framework perspective:Reviewed-by: Loic Poulain <redacted> ---
@@ -412,6 +651,7 @@ static struct t7xx_modem *t7xx_md_alloc(struct t7xx_pci_dev *t7xx_dev)
...
md->core_md.ready = false; + md->core_md.handshake_ongoing = false;
These assignments are not needed with mem from kzalloc. Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> -- i.