Re: [PATCH net-next v5 03/13] net: wwan: t7xx: Add core components
From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Date: 2022-02-25 11:10:35
Also in:
linux-wireless
On Wed, 23 Feb 2022, Ricardo Martinez wrote:
From: Haijun Liu <haijun.liu@mediatek.com> Registers the t7xx device driver with the kernel. Setup all the core components: PCIe layer, Modem Host Cross Core Interface (MHCCIF), modem control operations, modem state machine, and build infrastructure. * PCIe layer code implements driver probe and removal. * MHCCIF provides interrupt channels to communicate events such as handshake, PM and port enumeration. * Modem control implements the entry point for modem init, reset and exit. * The modem status monitor is a state machine used by modem control to complete initialization and stop. It is used also to propagate exception events reported by other components. Signed-off-by: Haijun Liu <haijun.liu@mediatek.com> Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com> Co-developed-by: Ricardo Martinez <ricardo.martinez@linux.intel.com> Signed-off-by: Ricardo Martinez <ricardo.martinez@linux.intel.com>quoted
From a WWAN framework perspective:Reviewed-by: Loic Poulain <redacted> ---
+ /* IPs enable interrupts when ready */ + for (i = 0; i < EXT_INT_NUM; i++) + t7xx_pcie_mac_clear_int(t7xx_dev, i);
In v4, PCIE_MAC_MSIX_MSK_SET() wrote to IMASK_HOST_MSIX_SET_GRP0_0. In v5, t7xx_pcie_mac_clear_int() writes to IMASK_HOST_MSIX_CLR_GRP0_0. t7xx_pcie_mac_set_int() would write to IMASK_HOST_MSIX_SET_GRP0_0 matching to what v4 did. So you probably want to call t7xx_pcie_mac_set_int() instead of t7xx_pcie_mac_clear_int()? -- i.