Re: [PATCH net 1/7] bnxt_en: Fix active FEC reporting to ethtool
From: Michael Chan <michael.chan@broadcom.com>
Date: 2022-02-22 20:06:40
On Tue, Feb 22, 2022 at 11:23 AM Jakub Kicinski [off-list ref] wrote:
On Sun, 20 Feb 2022 04:05:47 -0500 Michael Chan wrote:quoted
From: Somnath Kotur <redacted> ethtool --show-fec <interface> does not show anything when the Active FEC setting in the chip is set to None. Fix it to properly return ETHTOOL_FEC_OFF in that case.Just to be clear - this means: - the chip supports FEC but None is selected? Or - the chip does not support FEC?
This patch is only changing the reporting of the active FEC setting to be ETHTOOL_FEC_OFF if firmware determines the negotiated or actual FEC setting to be None. It is not changing the reporting of the chip's FEC capability or the user's selected FEC setting.
Attachments
- smime.p7s [application/pkcs7-signature] 4209 bytes