Re: [PATCH v3 net-next 02/11] net: bridge: vlan: don't notify to switchdev master VLANs without BRENTRY flag

On 16/02/2022 13:10, Vladimir Oltean wrote:

On Wed, Feb 16, 2022 at 01:00:27PM +0200, Nikolay Aleksandrov wrote:

quoted

quoted

+		if (br_vlan_should_use(v)) {
+			err = br_switchdev_port_vlan_add(dev, v->vid, flags,
+							 extack);
+			if (err && err != -EOPNOTSUPP)
+				goto out;
+		}

At some point we should just pass the vlan struct to the switchdev handlers
and push all the switchdev-specific checks in there. It would require some
care w.r.t kconfig options, but it should be cleaner.
The patch looks good.

Acked-by: Nikolay Aleksandrov <redacted>

Here and there we're passing "flags" and not "v->flags", so passing the
net_bridge_vlan structure to br_switchdev_port_vlan_add() would require
committing to it the changes we want to do, which is pretty much what
we've been avoiding since v1.

No, it won't. I didn't say we should stop passing flags.
It will be passed along with the vlan struct where you'd have the old flags
that you pass separately now, so all checks can be done on it.