Re: [PATCH v3 net-next 02/11] net: bridge: vlan: don't notify to switchdev master VLANs without BRENTRY flag
flat view
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2022-02-16 11:10:40
On Wed, Feb 16, 2022 at 01:00:27PM +0200, Nikolay Aleksandrov wrote:
quoted
+ if (br_vlan_should_use(v)) { + err = br_switchdev_port_vlan_add(dev, v->vid, flags, + extack); + if (err && err != -EOPNOTSUPP) + goto out; + }At some point we should just pass the vlan struct to the switchdev handlers and push all the switchdev-specific checks in there. It would require some care w.r.t kconfig options, but it should be cleaner. The patch looks good. Acked-by: Nikolay Aleksandrov <redacted>
Here and there we're passing "flags" and not "v->flags", so passing the net_bridge_vlan structure to br_switchdev_port_vlan_add() would require committing to it the changes we want to do, which is pretty much what we've been avoiding since v1.