Thread (19 messages) 19 messages, 6 authors, 2022-01-26

Re: [RFC bpf-next 1/2] net: bridge: add unstable br_fdb_find_port_from_ifindex helper

From: Lorenzo Bianconi <lorenzo@kernel.org>
Date: 2022-01-26 14:04:59
Also in: bpf

Lorenzo Bianconi [off-list ref] writes:
quoted
quoted
quoted
+	rcu_read_lock();
This is not needed when the function is only being called from XDP...
don't we need it since we do not hold the rtnl here?
No. XDP programs always run under local_bh_disable() which "counts" as
an rcu_read_lock(); I did some cleanup around this a while ago, see this
commit for a longer explanation:

782347b6bcad ("xdp: Add proper __rcu annotations to redirect map entries")
ack, right, I missed it. I will fix it.

Regards,
Lorenzo
-Toke

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help