RE: [PATCH bpf v2 4/4] bpf: Fix documentation of th_len in bpf_tcp_{gen,check}_syncookie
From: John Fastabend <john.fastabend@gmail.com>
Date: 2022-01-25 08:38:03
Also in:
bpf
Maxim Mikityanskiy wrote:
bpf_tcp_gen_syncookie and bpf_tcp_check_syncookie expect the full length
of the TCP header (with all extensions). Fix the documentation that says
it should be sizeof(struct tcphdr).
Fixes: 399040847084 ("bpf: add helper to check for a valid SYN cookie")
Fixes: 70d66244317e ("bpf: add bpf_tcp_gen_syncookie helper")
Signed-off-by: Maxim Mikityanskiy <redacted>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>Not sure I would push doc fixes at bpf tree, would be fine to go through bpf-next. But change looks good. Acked-by: John Fastabend <john.fastabend@gmail.com>