On Mon, Jan 3, 2022 at 6:52 AM Hector Martin [off-list ref] wrote:

On 2022/01/02 14:38, Linus Walleij wrote:

quoted

On Sun, Dec 26, 2021 at 4:37 PM Hector Martin [off-list ref] wrote:

quoted

On Apple platforms, the One Time Programmable ROM in the Broadcom chips
contains information about the specific board design (module, vendor,
version) that is required to select the correct NVRAM file. Parse this
OTP ROM and extract the required strings.

Note that the user OTP offset/size is per-chip. This patch does not add
any chips yet.

Signed-off-by: Hector Martin <redacted>

Overall looks fine!

quoted

+       const char *chip_params;
+       const char *module_params;

This variable name "module_params" is a bit confusing since loadable
kernel modules have params...

Can we think of another name and just put a comment that this
refers to the WiFi module building block?

Sometimes people talk about SoM:s (system-on-modules), so
maybe som_params or brcm_som_params?

Yours,
Linus Walleij

How about board_params, since we're already calling those things boards
elsewhere in the driver? That could refer to the board of a standalone
module, or an integrated board, which should cover all cases.

Fair enough, go for board_params!

Yours,
Linus Walleij