On Sun, Dec 26, 2021 at 4:40 PM Hector Martin [off-list ref] wrote:

The alignment check was wrong (e.g. & 4 instead of & 3), and the logic
was also inefficient if the length was not a multiple of 4, since it
would needlessly fall back to copying the entire buffer bytewise.

We already have a perfectly good memcpy_toio function, so just call that
instead of rolling our own copy logic here. brcmf_pcie_init_ringbuffers
was already using it anyway.

Fixes: 9e37f045d5e7 ("brcmfmac: Adding PCIe bus layer support.")
Signed-off-by: Hector Martin <redacted>

Excellent patch.
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij