RE: [PATCH iproute2-next 1/2] ip: GTP support in ip link

-----Original Message-----
From: Stephen Hemminger <stephen@networkplumber.org>
Sent: czwartek, 27 stycznia 2022 18:14
To: Drewek, Wojciech <redacted>
Cc: netdev@vger.kernel.org; dsahern@gmail.com; michal.swiatkowski@linux.intel.com; marcin.szycik@linux.intel.com
Subject: Re: [PATCH iproute2-next 1/2] ip: GTP support in ip link

On Thu, 27 Jan 2022 14:13:54 +0100
Wojciech Drewek [off-list ref] wrote:

quoted

+		if (role == GTP_ROLE_SGSN)
+			print_string(PRINT_ANY, "role", "role %s ", "sgsn");
+		else
+			print_string(PRINT_ANY, "role", "role %s ", "ggsn");

Why not us trigraph?
		print_string(PRINT_ANY, "role", "role %s ",
				role == GTP_ROLE_SGSN ? "sgsn" : "ggsn");

Just not a big fan of it, I'm not used to using it. It might look smooth here though.